Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class

[Tommy Christensen <tommy.christensen@xxxxxxxxx>]

On Wed, 2004-10-27 at 00:28, Thomas Graf wrote:
> +static inline long
> +cls_set_class(struct tcf_proto *tp, unsigned long *clp, 
> +     unsigned long cl)
> +{
> +     unsigned long old_cl;
> +     
> +     qdisc_lock_tree(tp->q->dev);
> +
> +     tcf_tree_lock(tp);
> +     old_cl = __cls_set_class(clp, cl);
> +     tcf_tree_unlock(tp);
> + 
> +     return old_cl;
> +}
> +

This locks once too many.
(And it returns an *unsigned* long.)

-Tommy