| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Change masquerade code to use first IP address of interface. |
| From: | Rusty Russell <rusty@xxxxxxxxxxxxxxx> |
| Date: | Thu, 21 Oct 2004 10:50:49 +1000 |
| Cc: | Henrik Nordstrom <hno@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Netfilter development mailing list <netfilter-devel@xxxxxxxxxxxxxxxxxxx> |
| In-reply-to: | <20041020111245.GA22703@gondor.apana.org.au> |
| References: | <E1CKBtq-0005FC-00@gondolin.me.apana.org.au> <Pine.LNX.4.61.0410201123200.25590@filer.marasystems.com> <20041020104650.GA20868@gondor.apana.org.au> <Pine.LNX.4.61.0410201300580.28452@filer.marasystems.com> <20041020111245.GA22703@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 2004-10-20 at 21:12, Herbert Xu wrote: > On Wed, Oct 20, 2004 at 01:04:51PM +0200, Henrik Nordstrom wrote: > > On Wed, 20 Oct 2004, Herbert Xu wrote: > > > > >I mean > > > > > > rt = (struct rtable *)(*pskb)->dst; > > > newsrc = inet_select_addr(out, rt->rt_gateway, RT_SCOPE_UNIVERSE); > > > > IIRC we are not allowed to access this here, but I may be wrong.. If we > > Why? POST_ROUTING is called in three places in ip_output.c and they all > give a valid dst. In fact ip_refrag in ip_conntrack_standalone.c is also > accessing skb->dst. Yeah, I like it. Please send patch on top of mine to Dave, and we'll see what blows up. Rusty. -- Anyone who quotes me in their signature is an idiot -- Rusty Russell |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Make netif_rx_ni preempt-safe, Herbert Xu |
|---|---|
| Next by Date: | r8169 - dac testing (was: [mini-RFT] r8169 and amd64), Srihari Vijayaraghavan |
| Previous by Thread: | Re: [PATCH] Change masquerade code to use first IP address of interface., Herbert Xu |
| Next by Thread: | Re: [PATCH] Change masquerade code to use first IP address of interface., David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |