netdev
[Top] [All Lists]

Re: [PATCH] Clean up fib_hash datastructures

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Clean up fib_hash datastructures
From: jamal <hadi@xxxxxxxxxx>
Date: 19 Sep 2004 20:39:43 -0400
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040918203319.24004d6e.davem@davemloft.net>
Organization: jamalopolous
References: <20040918203319.24004d6e.davem@davemloft.net>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 2004-09-18 at 23:33, David S. Miller wrote:
> So, before we even think about trying new faster algorithms
> in net/ipv4/fib_hash.c we have to clean it up.

Will look at rest of patch and get back to you. Curious piece like you
note:


> Does anyone know what this test:
> 
>               if (!iter->zone->fz_next)
>                       continue;
> 
> in fib_get_first() is doing?  I kept it there
> but it looks fishy.  

Yes, it is fishy;-> patch attached. Probably one of the more interesting
typos i have seen recently

cheers,
jamal



Attachment: fibhash_p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>