| To: | Ganesh Venkatesan <ganesh.venkatesan@xxxxxxxxx> |
|---|---|
| Subject: | Re: [patch 3/8 2.5] e1000 - Fix MODULE_PARM, module_param and module_param_array usage |
| From: | Scott Feldman <sfeldma@xxxxxxxxx> |
| Date: | Fri, 17 Sep 2004 19:59:13 -0700 |
| Cc: | jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <Pine.LNX.4.44.0409170231510.15233-100000@isotope.jf.intel.com> |
| References: | <Pine.LNX.4.44.0409170231510.15233-100000@isotope.jf.intel.com> |
| Reply-to: | sfeldma@xxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Fri, 2004-09-17 at 02:57, Ganesh Venkatesan wrote: > @@ -306,5 +312,9 @@ e1000_check_options(struct e1000_adapter > "Warning: no configuration for board #%i\n", bd); > DPRINTK(PROBE, NOTICE, "Using defaults for all values\n"); > #ifndef module_param_array > - bd = E1000_MAX_NIC; > #endif > } Is that leaving an empty #ifndef/#endif ? -scott |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [patch 2/5 2.4] e1000 - Fix MODULE_PARM, module_param and module_param_array usage, Scott Feldman |
|---|---|
| Next by Date: | Re: [patch 4/8 2.5] e1000 Check value returned by from pci_enable_device, Scott Feldman |
| Previous by Thread: | [patch 3/8 2.5] e1000 - Fix MODULE_PARM, module_param and module_param_array usage, Ganesh Venkatesan |
| Next by Thread: | [patch 5/8 2.5] e1000 - Fix VLAN filter setup errors (while running on PPC), Ganesh Venkatesan |
| Indexes: | [Date] [Thread] [Top] [All Lists] |