| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] NETIF_F_LLTX for devices 2 |
| From: | jamal <hadi@xxxxxxxxxx> |
| Date: | 10 Sep 2004 09:33:35 -0400 |
| Cc: | ak@xxxxxxx, herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040908134713.1bcd46d3.davem@davemloft.net> |
| Organization: | jamalopolis |
| References: | <20040908065152.GC27886@wotan.suse.de> <E1C4wYe-0005qT-00@gondolin.me.apana.org.au> <20040908072408.GI27886@wotan.suse.de> <1094629677.1089.155.camel@jzny.localdomain> <20040908134713.1bcd46d3.davem@davemloft.net> |
| Reply-to: | hadi@xxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 2004-09-08 at 16:47, David S. Miller wrote: > > We are merely moving the sch_generic.c locking logic into the > drivers. The behavior is entirely equivalent except that one > level of unnecessary locking has been removed. > > I think his change is valid, will not break existing drivers (as > you mentioned as well Jamal), and works well for the cases he has > shown patches of. So I'm going to apply his patch. > > BTW, if we are really concerned about some existing driver returning > -1 from hard_start_xmit() without the new feature flag being enabled, > we can test for that and log a debugging message if it happens. I am not 100% happy but let me do some testing on it. Would the best image be the latest bk snapshot? cheers, jamal |
| Previous by Date: | Re: iproute2 patch introducing mtu/txqlen/weight via rtnetlink, jamal |
|---|---|
| Next by Date: | [PATCH 2.6 NET] Device name changing via rtnetlink, Thomas Graf |
| Previous by Thread: | Re: [PATCH] NETIF_F_LLTX for devices 2, David S. Miller |
| Next by Thread: | Re: [PATCH] NETIF_F_LLTX for devices 2, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |