On Fri, 2004-08-13 at 20:00, Stephen Hemminger wrote:
> Okay, here is a new version of iproute2 with your last round of CLS patches
> incorporated in. Note: I fixed up some things that seemed to have changed in
> the current version of pkt_cls.h
>
> Also:
> - removed all #ifdef CONFIG_ from the command.
> - copy of kernel headers is now in iproute2/include/linux so that
> it will build without matching kernel headers.
> - this reduces the amount of configuration necessary.
>
> I don't want this final until you go over it Jamal, cause I had to rework your
> stuff enough that I probably broke it.
It was broken already because of latest kernel changes. Heres a patch on
top of what you have that fixes it. I have not run my full regression
tests on it (will do later next week) but basic tests all pass.
Note that i think you may have a typo in your bit conversion for rates.
Example:
--
[root@jzny tc]# ./tc filter add dev eth0 parent ffff: protocol ip prio 6
u32 match ip src 10.0.0.1/32 flowid 1:16 police rate 1kbit burst 90k
drop
[root@jzny tc]# ./tc -s filter show parent ffff: dev eth0
filter protocol ip pref 6 u32
filter protocol ip pref 6 u32 fh 800: ht divisor 1
filter protocol ip pref 6 u32 fh 800::800 order 2048 key ht 800 bkt 0
flowid 1:16
police 1 action drop rate 125bps burst 90Kb mtu 2Kb
match 0a000001/ffffffff at 12
Sent 0 bytes 0 pkts (dropped 0, overlimits 0)
--
125bps Should be 125Bps which is 1Kbits/sec, no?
cheers,
jamal
p1
Description: Text document
|