Re: [PATCH] common code for generating tcp_info

[Joe Perches <joe@xxxxxxxxxxx>]

On Fri, 2004-06-04 at 15:37, Stephen Hemminger wrote:

> diff -Nru a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c
> --- a/net/ipv4/tcp_diag.c     2004-06-04 15:35:55 -07:00
> +++ b/net/ipv4/tcp_diag.c     2004-06-04 15:35:55 -07:00
> +void tcp_get_info(struct sock *sk, struct tcp_info *info)

What is the appropriate text to update tcp.h?

        /* The syn_wait_lock is necessary only to avoid tcp_get_info having
         * to grab the main lock sock while browsing the listening hash
         * (otherwise it's deadlock prone).
         * This lock is acquired in read mode only from tcp_get_info() and
         * it's acquired in write mode _only_ from code that is actively
         * changing the syn_wait_queue. All readers that are holding
         * the master sock lock don't need to grab this lock in read mode
         * too as the syn_wait_queue writes are always protected from
         * the main sock lock.
         */