| To: | Andi Kleen <ak@xxxxxxx> |
|---|---|
| Subject: | Re: some bluetooth fixes |
| From: | Marcel Holtmann <marcel@xxxxxxxxxxxx> |
| Date: | Sat, 07 Feb 2004 00:30:08 +0100 |
| Cc: | bluez-devel@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20040206050042.20a2b3b0.ak@suse.de> |
| References: | <20040206050042.20a2b3b0.ak@suse.de> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Hi Andi,
> diff -u linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c-o
> linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c
> --- linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c-o 2003-09-28
> 10:53:25.000000000 +0200
> +++ linux-2.6.2-work32/net/bluetooth/rfcomm/tty.c 2004-02-06
> 04:58:28.000000000 +0100
> @@ -549,8 +549,10 @@
>
> BT_DBG("dev %p dst %s channel %d opened %d", dev, batostr(&dev->dst),
> dev->channel, dev->opened);
>
> - if (dev->opened++ != 0)
> + if (dev->opened++ != 0) {
> + rfcomm_dev_put(dev);
> return 0;
> + }
>
> dlc = dev->dlc;
this part is wrong, because it is not an error case. It is success and
the refcount must stay increased.
Regards
Marcel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/3] IPV6: clean-up DAD vs tentative address, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH 2/3] IPV6: unify 3 similar code path in ndisc_recv_ns(), David S. Miller |
| Previous by Thread: | Re: some bluetooth fixes, Marcel Holtmann |
| Next by Thread: | Re: some bluetooth fixes, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |