netdev
[Top] [All Lists]

Re: [PATCH 2.6]: IPv4: strcpy -> strlcpy

To: Felipe Alfaro Solana <felipe_alfaro@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6]: IPv4: strcpy -> strlcpy
From: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
Date: Fri, 28 Nov 2003 09:42:18 +0000
Cc: Timo Kamph <timo@xxxxxxxxx>, Linux Kernel Mailinglist <linux-kernel@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, davem@xxxxxxxxxx
In-reply-to: <1069970946.2138.13.camel@teapot.felipe-alfaro.com>
References: <20031127142125.GG8276@jdj5.mit.edu> <3FC67128.14704.30155D53@localhost> <1069970946.2138.13.camel@teapot.felipe-alfaro.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 2003-11-27 at 23:09 +0100, Felipe Alfaro Solana wrote:
> On Thu, 2003-11-27 at 21:48, Timo Kamph wrote:
> 
> > > + strlcpy(label->label, name, sizeof(label->name));
> >                                                                        
> > ^^^^^^
> > I guess this shoud be label->label, or am I wrong?
> 
> Oh my god! Two consecutive mistakes with the same patch! I should have
> some sleep... Here's the one with the typo corrected.

Perhaps we should consider

#define strsizecpy(x, y) strlcpy((x), (y), sizeof(x))

-- 
dwmw2


<Prev in Thread] Current Thread [Next in Thread>