Re: [PATCH] 2.6.0-bk6 net/core/dev.c

netdev

Re: [PATCH] 2.6.0-bk6 net/core/dev.c

To:	Linus Torvalds <torvalds@xxxxxxxx>
Subject:	Re: [PATCH] 2.6.0-bk6 net/core/dev.c
From:	Joe Perches <joe@xxxxxxxxxxx>
Date:	Wed, 24 Sep 2003 10:17:47 -0700
Cc:	David S Miller <davem@xxxxxxxxxx>, Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to:	<Pine.LNX.4.44.0309241012110.3178-100000@home.osdl.org>
References:	<Pine.LNX.4.44.0309241012110.3178-100000@home.osdl.org>
Sender:	netdev-bounce@xxxxxxxxxxx

On Wed, 2003-09-24 at 10:13, Linus Torvalds wrote:
> Looks sane, but wouldn't it be cleaner to put this ugly special case logic
> with casts etc in an inline function and make the code a bit more readable
> at the same time?

I've got those.

I've done the ((void*)1) conversions to PKT_SHARED_SKBs
and found this missing.  I'll submit those separately.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] 2.6.0-bk6 net/core/dev.c, Joe Perches Re: [PATCH] 2.6.0-bk6 net/core/dev.c, Linus Torvalds Re: [PATCH] 2.6.0-bk6 net/core/dev.c, Joe Perches <= [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h, Joe Perches Re: [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h, Linus Torvalds Re: [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h, David S. Miller Re: [PATCH] 2.6.0-bk6 net/core/dev.c, David S. Miller [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [2/3] drivers/net/, Joe Perches* [PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [3/3] net/, Joe Perches*

Previous by Date:	Re: [PATCH] 2.6.0-bk6 net/core/dev.c, Linus Torvalds
Next by Date:	Re: assertion (dev->qdisc_list == NULL) failed at net/sched/sch_generic.c(530), Thomas Graf
Previous by Thread:	Re: [PATCH] 2.6.0-bk6 net/core/dev.c, Linus Torvalds
Next by Thread:	[PATCH] 2.6.0-test5-bk11 PKT_CAN_SHARE_SKB [1/3] include/linux/netdevice.h, Joe Perches
Indexes:	[Date] [Thread] [Top] [All Lists]