netdev
[Top] [All Lists]

Re: [PATCH] (1/4) Update baycom drivers for 2.6

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] (1/4) Update baycom drivers for 2.6
From: Thomas Sailer <t.sailer@xxxxxxxxxxxxxx>
Date: 22 Sep 2003 15:55:44 +0200
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, linux-hams@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20030920144812.0c587a12.shemminger@osdl.org>
Organization: private
References: <20030919133750.4053f72c.shemminger@osdl.org> <3F6CA3E3.9060909@pobox.com> <20030920144812.0c587a12.shemminger@osdl.org>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 2003-09-20 at 23:48, Stephen Hemminger wrote:

Patch 1-3 look good.

> patch 4 was replacing local random with get_random_bytes.
> Probably not a good idea since people seem to be paranoid
> about losing entropy ...

Yes, IMO not a good idea to use entropy for such a simple task.
The random numbers are used for the channel access algorithm, and
nothing bad happens if they are predictable.

Tom


<Prev in Thread] Current Thread [Next in Thread>