| To: | "'Arthur Kepner'" <akepner@xxxxxxx>, "'Anton Blanchard'" <anton@xxxxxxxxx> |
|---|---|
| Subject: | RE: [PATCH] s2io: replace readq() with mmiowb() in s2io_xmit() |
| From: | "Ramkrishna Vepa" <ram.vepa@xxxxxxxxxxxx> |
| Date: | Mon, 2 May 2005 19:58:38 -0700 |
| Cc: | "'Leonid Grossman'" <leonid.grossman@xxxxxxxxxxxx>, <muhammad.shafiq@xxxxxxxxxxxx>, <ramkrishna.vepa@xxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, "'Ravinandan Arakali'" <ravinandan.arakali@xxxxxxxxxxxx> |
| Importance: | Normal |
| In-reply-to: | <Pine.LNX.4.61.0505021844480.16692@linux.site> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
> > I didnt know mmiowb is supposed to be a replacement for PCI write > > posting. Most architectures define mmiowb as nothing and so will be > > broken with your change. > > > > I thought that an arch was supposed to define mmiowb() if it needs > it. In this case, the readq() is only being used for the side-effect > of ordering the previous writes (the neterion folks can correct me > if I'm wrong). [Ram] Yes, it is to ensure ordering as well as the flush of the io that is required in some platforms. > > -- > Arthur |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] s2io: replace readq() with mmiowb() in s2io_xmit(), Arthur Kepner |
|---|---|
| Next by Date: | Re: [PATCH] s2io: replace readq() with mmiowb() in s2io_xmit(), Anton Blanchard |
| Previous by Thread: | Re: [PATCH] s2io: replace readq() with mmiowb() in s2io_xmit(), Arthur Kepner |
| Next by Thread: | Re: [PATCH] s2io: replace readq() with mmiowb() in s2io_xmit(), Anton Blanchard |
| Indexes: | [Date] [Thread] [Top] [All Lists] |