netdev
[Top] [All Lists]

RE: Submission #4 for S2io 10GbE driver

To: "'Jeff Garzik'" <jgarzik@xxxxxxxxx>, "'Leonid Grossman'" <leonid.grossman@xxxxxxxx>
Subject: RE: Submission #4 for S2io 10GbE driver
From: "ravinandan arakali" <ravinandan.arakali@xxxxxxxx>
Date: Mon, 22 Mar 2004 11:36:18 -0800
Cc: <netdev@xxxxxxxxxxx>, <raghavendra.koushik@xxxxxxxx>, <alicia.pena@xxxxxxxx>, "'Huy Phan'" <peter.phan@xxxxxxxx>
Importance: Normal
In-reply-to: <405C1656.8080004@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx
Hi Jeff,
Thanks for the patch cleanup.
Can you pls send us the final copy of s2ioDriver.patch file that you
applied
to the 2.6 kernel ? 

Regards,
Ravi

-----Original Message-----
From: Jeff Garzik [mailto:jgarzik@xxxxxxxxx] 
Sent: Saturday, March 20, 2004 2:01 AM
To: Leonid Grossman
Cc: netdev@xxxxxxxxxxx; 'ravinandan arakali';
raghavendra.koushik@xxxxxxxx
Subject: Re: Submission #4 for S2io 10GbE driver

Jeff Garzik wrote:
> ===== drivers/net/s2io.h 1.1 vs 1.2 =====
> --- 1.1/drivers/net/s2io.h    Sat Mar 20 04:38:16 2004
> +++ 1.2/drivers/net/s2io.h    Sat Mar 20 04:47:53 2004
> @@ -14,8 +14,8 @@
>  #define _S2IO_H
>  
>  #define TBD 0
> -#define BIT(loc)        (((u64)0x8000000000000000ULL) >> loc)
> -#define vBIT(val, loc, sz)  (((u64)val) << (64-loc-sz))
> +#define BIT(loc)             (1ULL << (loc))
> +#define vBIT(val, loc, sz)   (((u64)val) << (64-loc-sz))

and here is a patch correcting an incorrect cleanup...



<Prev in Thread] Current Thread [Next in Thread>