netdev
[Top] [All Lists]

RE: Patch submission for S2io Xframe driver to 2.6 kernel

To: "'Jeff Garzik'" <jgarzik@xxxxxxxxx>
Subject: RE: Patch submission for S2io Xframe driver to 2.6 kernel
From: "Ravinandan Arakali" <ravinandan.arakali@xxxxxxxx>
Date: Wed, 6 Oct 2004 13:14:24 -0700
Cc: <netdev@xxxxxxxxxxx>, <leonid.grossman@xxxxxxxx>, <raghavendra.koushik@xxxxxxxx>, <rapuru.sriram@xxxxxxxx>
Importance: Normal
In-reply-to: <41597DA4.5040200@pobox.com>
Reply-to: <ravinandan.arakali@xxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Hi Jeff and others,
We have now split the submission into 8 patches.
Attached is the first patch. It contains mostly
cosmetic changes such as style of comments,
indentation, structure name changes as per linux convention
etc.

Please let us know if you want us to send the subsequent
patches one-after-another right now, or do you want us
to send them only after you have completed review and accepted
this first patch.

Thanks,
Ravi 

-----Original Message-----
From: Jeff Garzik [mailto:jgarzik@xxxxxxxxx]
Sent: Tuesday, September 28, 2004 8:05 AM
To: ravinandan.arakali@xxxxxxxx
Cc: netdev@xxxxxxxxxxx; leonid.grossman@xxxxxxxx;
raghavendra.koushik@xxxxxxxx; rapuru.sriram@xxxxxxxx
Subject: Re: Patch submission for S2io Xframe driver to 2.6 kernel


Ravinandan Arakali wrote:
> Hi,
> Attached are the updated patches. It is designed to work on the latest
> kernel. Also, this time the submission is split to 3 patches(they need
> to applied in the order mentioned below).
> 
> s2io_styling_level1  - Contains
>                              a. styling related, function name changes.
>                              b. fix for 32-bit systems.
>                              c. modified Transmit descriptor allocation
> strategy.
>                              d. miscellaneous fixes.


When we say "separate logical changes", we mean it :)

This means that your level1 patch should be split into at least 4 patches.

Second, send each patch in a separate email, as described in
http://linux.yyz.us/patch-format.html (and 
Documentation/SubmittingPatches) rather than sending as a tarball.

        Jeff

Attachment: s2io_cosmetic.patch1
Description: Binary data

<Prev in Thread] Current Thread [Next in Thread>