Re: FW: drivers/block/dump.c fixes

[Bharata B Rao <bharata@xxxxxxxxxx>]

On Fri, Sep 21, 2001 at 11:49:43AM -0700, Monty Vanderbilt wrote:
> 
> 2) RDWR permission check is not required for query ioctls.
> 
> --- 2.4/drivers/block/dump.c  Mon Sep 17 12:00:14 2001
> +++ 2.4fix/linux/drivers/block/dump.c Fri Sep 21 11:07:59 2001
> @@ -211,9 +211,9 @@
> 
> -     /* check flags */
> -     if (!(f->f_flags & O_RDWR)) {
> -             return (-EPERM);
> +     switch (cmd) {
> +             case DIOSDUMPDEV:
> +             case DIOSDUMPLEVEL:
> +             case DIOSDUMPFLAGS:
> +             case DIOSDUMPCOMPRESS:
> +                     /* check flags */
> +                     if (!(f->f_flags & O_RDWR)) {
> +                         return (-EPERM);
> +                     }
>       }
> 

Just checked out this file from cvs. This is causing "duplicate case value" 
error for DIOSDUMPDEV, DIOSDUMPLEVEL, DIOSDUMPFLAGS and DIOSDUMPCOMPRESS.
Did you not get this error ?

> Monty VanderBilt
> mvb@xxxxxxxxxx

Regards,
Bharata.
-- 
Bharata B Rao,
IBM Linux Technology Center,
IBM Software Lab, Bangalore.

Ph: 91-80-5262355 Ex: 3962
Mail: bharata@xxxxxxxxxx