regs will be NULL if we use sysrq-trigger to invoke SysRq key. Noticed on
LKCD, but not sure whether it could apply on KDB.
Example: echo 'd' > /proc/sysrq-trigger.
Sent by: kdb-bounce@xxxxxxxxxxx
To: Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx>
cc: anton@xxxxxxxxx, kdb@xxxxxxxxxxx, linuxppc64-dev@xxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] fix KDB backtrace for ppc64
On Wed, May 05, 2004 at 07:16:47PM +0500, Ananth N Mavinakayanahalli
wrote:
> @@ -200,25 +196,49 @@ kdba_bt_stack_ppc(struct pt_regs *regs,
> + if (!flag && (task_curr(p))) {
> +
> + lr = regs->link;
Its not obvious that regs might not be a null pointer. Code
higher up tries to make sure that regs is set to something,
but its not clear that every branch is correctly handled.
Other than that, the patch looks reasonable.
--linas
---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
|