| To: | Jason Wessel <jason.wessel@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 10/37] kgdb: Make mem access function weak in kgdb.c and kgdb.h |
| From: | Mike Frysinger <vapier.adi@xxxxxxxxx> |
| Date: | Sat, 26 Dec 2009 16:07:10 -0500 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx, kdb@xxxxxxxxxxx, mingo@xxxxxxx, Sonic Zhang <sonic.adi@xxxxxxxxx> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=a9nV780n/O6FDzvYRkJpF+hx/S4X64DDFyh875EfZuQ=; b=bk45jpEdGZXulUpaqSgiV6ieQ9fKSpf0kMQbA+NwCNrmuIwZp3XVq7+1m1OkBFztD1 tVVwzxPljR/Ksl/Cmjvtr3iLU+3MtXyy52Z7QxdexbyX4ReVZscJJe3p61oDUKjO84+y nvj0SWVPZRfW0M+KiW7dh31Hs/ny5DoaLh3xw= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=XxdA/etZnPLdrFzclMGW89F6SuRVr2mUmmeVIFYx4kKCg5kNlFEALoyx4VXTjbJKpV k0PvS/+NmHAiO1FgDKrOZ3lNQiKCdilBNafYLj8Htv57IV54n7+sgQgJOrX3zoi9n/fd I5aKHDELBtzHWmtqQNM8iDgMBX/QredSP2mAU= |
| In-reply-to: | <1261603190-5036-11-git-send-email-jason.wessel@xxxxxxxxxxxxx> |
| References: | <1261603190-5036-1-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-3-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-4-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-5-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-6-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-7-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-8-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-9-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-10-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-11-git-send-email-jason.wessel@xxxxxxxxxxxxx> |
On Wed, Dec 23, 2009 at 16:19, Jason Wessel wrote: > L1 instruction memory and MMR memory on blackfin can not be accessed by > common functions probe_kernel_read() and probe_kernel_write(). > Blackfin asks for 2/4 byte align access to MMR memory and DMA access to > L1 instruction memory. These functions need to be reimplemented in > architecture specific kgdb.c. Update documentation and prototypes as > well. considering these functions were made weak only because of probe_kernel_(read|write), then perhaps it makes more sense to move the work there. it would mean that all consumers of these functions work properly instead of just kgdb. probe_kernel_write is already weak ... we just need to add weak to probe_kernel_read i think, and make the functions available via a "default" symbol so that arch overrides can tail back into the common code when it makes sense. -mike |
| Previous by Date: | Re: [PATCH 05/37] kdb: core for kgdb back end, Jason Wessel |
|---|---|
| Next by Date: | Re: [PATCH 09/37] kgdb,blackfin: Add in kgdb_arch_set_pc for blackfin, Mike Frysinger |
| Previous by Thread: | Re: [PATCH 14/37] sh,sh-sci: Use NO_POLL_CHAR in the SCIF polled console code, Paul Mundt |
| Next by Thread: | Re: [PATCH 09/37] kgdb,blackfin: Add in kgdb_arch_set_pc for blackfin, Mike Frysinger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |