Re: [kdb] [PATCH, RFC] merge i386 and x86_64 kdb arch code

["jidong xiao" <jidong.xiao@xxxxxxxxx>]

On Tue, Dec 23, 2008 at 5:16 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> The kdb arch code for i386 and x86_64 is to 98% essentially the same
> modulo a few tiniy differences that crept in over the years.  The real
> differences are:
>
>  - the register handling due to the additional registers and slightly
>   different ABI on x86_64
>  - setjmp / longjmp is different assembly code
>  - i386 has an stackdepth command.  I don't really see why it
>   doesn't exist for x86_64, but at least right now it's not there
>  - x86_64 has a cpu_pda command.  AFAIK the PDA doesn't exist on i386
>   in that form, so it's one to stay
>  - x86_64 registers a die notifier.  This looks like it would apply
>   to i386 too, but I'd like to leave it to an expert.
>
> The patch elow just merges all files.  A slightly cleaner version might
> be to have a kdba_regs_{32,64}.c for the register stuff instead of
> ifdefs.
>
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>

Did you miss something? It seems you are going to delete
kdbasupport_32.c and kdbasupport_64.c rather than merge them.

Regards
Jason