On Tue, 2 Mar 2004 18:56:26 -0600,
linas@xxxxxxxxxxxxxx wrote:
>On Wed, Mar 03, 2004 at 09:47:50AM +1100, Keith Owens wrote:
>>
>> One of the changes on my list for kdb v4.4 is to change kdb_serial_str
>> to <escape>KDB. Distributions/users can patch it to whatever they want.
>
>If there's no precedent, then I nominate "startKDB", so that it
>behaves as if there were a plain-old command called startKDB.
SGI already use <escape>KDB on Altix. We wanted a string that nobody
would type by mistake, especially when editting over a serial console
line. That meant using at least one unprintable character.
>Some minor nits while I work on this:
>
>-- some places you use spaces instead of tabs in the code, which
> results in funky indentation if tabstops is set to anything
> other than 8 (set ts=3 in vi, I think)
Historical. A white space clean up is also part of my plans for kdb
v4.4.
>-- drivers/serial/8250.c: In function `serial8250_console_setup':
> drivers/serial/8250.c:2050: warning: cast from pointer to integer of
> different size
>
> which works out to:
> kdb_serial.iobase = (int)(port->membase);
You have an old patch. kdb v4.3 for 2.4.25 drivers/char/serial.c
kdb_serial.iobase = (unsigned long)(info->iomem_base);
2.6.4-rc1 drivers/serial/8250.c
kdb_serial.iobase = (unsigned long)(port->membase);
---------------------------
Use http://oss.sgi.com/ecartis to modify your settings or to unsubscribe.
|