kdb
[Top] [All Lists]

Re: [PATCH 15/37] sparc,sunzilog: Add console polling support for sunzil

To: jason.wessel@xxxxxxxxxxxxx
Subject: Re: [PATCH 15/37] sparc,sunzilog: Add console polling support for sunzilog serial driver
From: David Miller <davem@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 14:00:46 -0800 (PST)
Cc: linux-kernel@xxxxxxxxxxxxxxx, kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx, kdb@xxxxxxxxxxx, mingo@xxxxxxx
In-reply-to: <4B3291AD.6070104@xxxxxxxxxxxxx>
References: <1261603190-5036-16-git-send-email-jason.wessel@xxxxxxxxxxxxx> <20091223.135028.112586698.davem@xxxxxxxxxxxxx> <4B3291AD.6070104@xxxxxxxxxxxxx>
From: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 15:54:53 -0600

> David Miller wrote:
>> From: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
>> Date: Wed, 23 Dec 2009 15:19:28 -0600
>>
>>   
>>> +static void sunzilog_put_poll_char(struct uart_port *port,
>>> +                   unsigned char ch)
>>> +{
>>> +   struct uart_sunzilog_port *up = (struct uart_sunzilog_port *)port;
>>> +
>>> +   sunzilog_putchar(&up->port, ch);
>>> +   udelay(2);
>>> +
>>> +}
>>> +#endif /* CONFIG_CONSOLE_POLL */
>>>     
>>
>> Just curious, what is the udelay() for?
>>   
> 
> This was copied from zm.c driver.  I don't think the HW needs it, I'll
> retest and purge it.
 ...
> Consider it done.

Thanks.

<Prev in Thread] Current Thread [Next in Thread>