kdb
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH 07/37] kgdb,sparc: Add in kgdb_arch_set_pc for sparc

from [David Miller] [Permanent Link][Original]
To: jason.wessel@xxxxxxxxxxxxx
Subject: Re: [PATCH 07/37] kgdb,sparc: Add in kgdb_arch_set_pc for sparc
From: David Miller <davem@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 13:48:37 -0800 (PST)
Cc: linux-kernel@xxxxxxxxxxxxxxx, kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx, kdb@xxxxxxxxxxx, mingo@xxxxxxx
In-reply-to: <1261603190-5036-8-git-send-email-jason.wessel@xxxxxxxxxxxxx>
References: <1261603190-5036-6-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-7-git-send-email-jason.wessel@xxxxxxxxxxxxx> <1261603190-5036-8-git-send-email-jason.wessel@xxxxxxxxxxxxx> 
From: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 15:19:20 -0600

> +void kgdb_arch_set_pc(struct pt_regs *regs, unsigned long ip)
> +{
> +       regs->pc = regs->npc;
> +       regs->npc = ip;
> +}
> +

Is this right?

It should probably be something like:

> +       regs->pc = ip;
> +       regs->npc = regs->pc + 4;

and similary for sparc64.
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [PATCH 37/37] kgdbts,sh: Add in breakpoint pc offset for superh, Jason Wessel
Next by Date:  Re: [PATCH 15/37] sparc,sunzilog: Add console polling support for sunzilog serial driver, David Miller
Previous by Thread:  Re: [PATCH 08/37] kgdb,sh: update superh kgdb exception handling, Paul Mundt
Next by Thread:  Re: [PATCH 07/37] kgdb,sparc: Add in kgdb_arch_set_pc for sparc, Jason Wessel
Indexes:  [Date] [Thread] [Top] [All Lists]