kaio
[Top] [All Lists]

Re: spotted in the kaio patch

To: Andrew Morton <andrewm@xxxxxxxxxx>
Subject: Re: spotted in the kaio patch
From: Rajagopal Ananthanarayanan <ananth@xxxxxxx>
Date: Mon, 19 Mar 2001 10:23:05 -0800
Cc: kaio@xxxxxxxxxxx
References: <3AB54B71.80DB2CC9@uow.edu.au>
Sender: owner-kaio@xxxxxxxxxxx
Andrew Morton wrote:
> 
> I was surfing this patch...
> 
> do_kaio_generic_read() does a page_cache_alloc() with the
> pagecache_lock held - can deadlock.

I'll look into this ...

> 
> In kaio_set_slave_name(), do this:
> 
>         current->mm->arg_start = current->mm->arg_end = 0;
> 
> and the slaves will look right in `ps'.

Ah, so that's the trick, thanks. I had always wanted to fix this,
but never got around to it. Interestingly top reports the correct
names even without this fix.

Just curious: did you find these bugs by running the patch or
by code examination?

cheers,

ananth.

-- 
--------------------------------------------------------------------------
Rajagopal Ananthanarayanan ("ananth")
Member Technical Staff, SGI.
--------------------------------------------------------------------------

<Prev in Thread] Current Thread [Next in Thread>