Christopher Smith wrote:
>
> I noticed a VERY small problem with the KAIO patch when applied to the
> latest 2.2 kernel. So, I put together this new patch which fixes the
> problem. Let me know if anyone has any problems.
>
> BTW, has anyone tried porting this to 2.3.x and sending it to Linus?
> This seems like a very nice feature (particulary since glibc AIO is both
> slow and buggy), particularly when combined with RAW I/O.
>
> --Chris
Chris,
For some reason your patch contains extra files with .orig extensions;
i gues you had some "saved" copies lying around when you ran the diff.
Due to this, the patch you sent out has 8000+ lines of diff, whereas
the original kaio-kern-1.0 has only 2000+ lines of diff. I tried
manually editing out the .orig diffs, but still couldn't find what
exactly your changes were. Can you please sending a corrected
version of the patch? Also, if the differences are not big,
could you also send the diffs (in text) in your reply.
Also, re: your question about 2.3.X ... this is one of the highest
priority items on my todo lists. Note that most of the changes
come in large chunks, so I'm hoping(!) that we can get away with
porting a significant portion of the code. I'm also happy to
see you find KAIO to be an improvement over glibc AIO.
I hope to get such feedback before pushing the patches onto linux-kernel
mailing list & thence to Linus et.al. If you (or anyone else
reading this message) has a quantification of KAIO vs. glibc-aio
w.r.t. performance or posix-compliance (or just difficult bugs),
that information will greatly influence in getting KAIO into kernel
proper.
regards,
ananth.
PS: btw, I'm having some logistical problem in trying to use my latest
kernel
on my test system, so i haven't tried the socket test yet.
|