On Wed, 16 Aug 2000, Jonathan Lim wrote:
Hi Nico, Jonathan,
Something to keep in mind when submitting check-ins ... Try not to write
code of the form:
#ifdef __linux__
// non IRIX specific code here
#else
// IRIX specific code here
#endif
but rather:
#ifndef __sgi
// non IRIX specific code here
#else
// IRIX specific code here
#endif
this will ensure that porting to other platforms != Linux will not be too
tedious and ensures that we don't break the IRIX build. In the current
tree there should only be 7 instances where we used the "#if(n)def
__linux__" stuff (if we count the lib and libSoXt directories only).
Actually, SoType.c++ demonstrates fairly well how not to do things (see
sgidlopen() stuff :)
A+,
Alex.
> Nico,
>
> Thanks for being the first to submit a patch. We'll look into getting it into
> the next release (no fixed schedule at this time).
>
>
> Jonathan Lim _ Silicon Graphics _ Mountain View
> GPS Graphics Computer Systems CA, USA
>
>
> On Wed Aug 16 19:49:07 2000, Nico.Schmidt@xxxxxxxxxx wrote:
> >
> > Since dynamic loading of nodes does not work on linux with the current
> > release, here is a patch to enable this.
> >
> > Apply it to inventor/lib/database/src/so/SoType.c++
> >
> > ---------- BEGIN SoType.patch -------------
> > 217c217,225
> > < #if (_MIPS_SIM == _MIPS_SIM_ABI32)
> > ---
> > >
> > > #ifdef __linux__
> > >
> > > #ifdef __i386
> > > const char *libDir = "lib";
> > > const char *abiName = "";
> > > #endif
> > >
> > > #elif (_MIPS_SIM == _MIPS_SIM_ABI32)
> > ---------- END SoType.patch -------------
> >
> > Regards,
> > Nico
> >
> > --
> > Nico Schmidt IPK/IWF eMail : nico.schmidt@xxxxxxxxxx
> > Sekr. PTZ 4, Pascalstr. 8-9 Phone : +49-30-39006342
> > D-10587 Berlin
>
--
Alexandre Naaman - naaman@xxxxxxx - La conformité est la mort de l'âme.
|