devfs
[Top] [All Lists]

Re[2]: [PATCH] fix initlog/minilogd deadlock on /dev/log access

To: "Pavel Roskin" <proski@xxxxxxx>
Subject: Re[2]: [PATCH] fix initlog/minilogd deadlock on /dev/log access
From: "Andrey Borzenkov" <arvidjaar@xxxxxxx>
Date: Tue, 06 May 2003 12:31:32 +0400
Cc: devfs@xxxxxxxxxxx
In-reply-to: <Pine.LNX.4.55.0305051731290.1184@marabou.research.att.com>
Reply-to: "Andrey Borzenkov" <arvidjaar@xxxxxxx>
Sender: devfs-bounce@xxxxxxxxxxx

> 
> On Tue, 6 May 2003, Andrey Borzenkov wrote:
> 
> > please, try attached proof-of-concept patch (untested). It is the best I can
> > come up with at 0:45 a.m.
> 
> Yes it helps, thank you!  5 reboots with original minilogd and rc.sysinit,
> no hangs.
> 

I'll wait till the end of week for any regression. Please tell if
you observe some.

After review the patch appears safe so I'll submit it for 2.4 tree.

> The patch also applies to Linux 2.5.69 and has no visible effect, which is
> good because that kernel was already OK.
> 

If it is applies it is bad. It means, unless locking rules has changed,
2.5 is likely to have the same deadlock situation.

thank you once more for excellent debugging work.

-andrey


<Prev in Thread] Current Thread [Next in Thread>