devfs
[Top] [All Lists]

RE: Possible problem with devfs removable drives patch

To: Borsenkow Andrej <Andrej.Borsenkow@xxxxxxxxxxxxxx>
Subject: RE: Possible problem with devfs removable drives patch
From: Robert.Fox@xxxxxxxxxxx (Robert Fox)
Date: 22 Feb 2002 08:51:11 +0100
Cc: "'Richard Gooch'" <rgooch@xxxxxxxxxxxxxxx>, "'devfs mailing list'" <devfs@xxxxxxxxxxx>, "'Paul Bristow'" <paul@xxxxxxxxxxxxxxx>, kernel@xxxxxxxxxxxxxxxx
In-reply-to: <003301c1bb73$a4973290$21c9ca95@mow.siemens.ru>
References: <003301c1bb73$a4973290$21c9ca95@mow.siemens.ru>
Sender: owner-devfs@xxxxxxxxxxx
So if I understand this correctly, there is an offending patch here and
it's not a problem with Richard's code.  That would mean I don't need to
download the 2.4.18-rc2 kernel (as Richard suggested) and recompile it
as refernece (without all the Mandrake patches)

Thanks Andrej - you saved me some considerable time here!

I guess I'll wait until someone says it's fixed and then test it  . . .

Have a nice weekend all!

- Robert


On Fri, 2002-02-22 at 08:36, Borsenkow Andrej wrote:
> > 
> > Borsenkow Andrej writes:
> > > Mandrake 2.4.17-18mdk based on 2.4.18-rc1
> > >
> > > On first (?) bootup after install the following interesting message
> > > (error -17):
> > >
> > > PIIX4: chipset revision 1
> > > PIIX4: not 100% native mode: will probe irqs later
> > >     ide0: BM-DMA at 0x1840-0x1847, BIOS settings: hda:pio, hdb:pio
> > >     ide1: BM-DMA at 0x1848-0x184f, BIOS settings: hdc:DMA, hdd:pio
> > > hda: LS-120 CSMO 05 UHD Floppy, ATAPI FLOPPY drive
> > > hdc: IBM-DTTA-371440, ATA DISK drive
> > > ide0 at 0x1f0-0x1f7,0x3f6 on irq 14
> > > ide1 at 0x170-0x177,0x376 on irq 15
> > > hdc: 28229040 sectors (14453 MB) w/462KiB Cache, CHS=28005/16/63,
> > > UDMA(33)
> > > hda: No disk in drive
> > > hda: 123264kB, 963/8/32 CHS, 533 kBps, 512 sector size, 720 rpm
> > > devfs_register(disc): could not append to parent, err: -17
> > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > 
> > Odd. This should never happen. If you look at the code for
> > devfs_register_disc(), you will see the very first line:
> >     if (dev->part[minor].de) return;
> > 
> > which prevents duplicate registrations.
> 
> I am sorry. Mandrake is using patch from Paul (that has been announced
> here as well, see another thread "Removeable Media, partitions and
> devfs?", patch is quite old actually.
> 
> idefloppy_setup registers "disc" itself:
> 
> /*
>  *      Driver initialization.
>  */
> static void idefloppy_setup (ide_drive_t *drive, idefloppy_floppy_t
> *floppy)
> {
> ...
>         /* Always register drive with devfs */
>         floppy->de = devfs_register (drive->de, "disc",
> DEVFS_FL_REMOVABLE,
>                                      major, minor,
>                                      S_IFBLK | S_IRUGO | S_IWUGO,
>                                      ide_fops, NULL);
>         /* Create ide/fd entry in devfs */                             
>         idefloppy_devfs_handle =
> devfs_mk_dir(ide_devfs_handle,"fd",NULL);
>         
>         sprintf (fname, "c%db%dt%du%d",
>                          ^^^^^^^^^^^^^
> Is not this a devfsd task?
> 
> It looks like handle for ..../disc never makes it way into gendisk at
> this point.
> 
> Is there newer patch? Paul, you probably should not create compat links
> in driver.
> 
> Robert, sorry, had to do closer look but really had no time :(
> 
> -andrej



<Prev in Thread] Current Thread [Next in Thread>