X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q3OJUFTk104754 for ; Tue, 24 Apr 2012 14:30:15 -0500 Received: from [128.162.232.130] (eagdhcp-232-130.americas.sgi.com [128.162.232.130]) by relay2.corp.sgi.com (Postfix) with ESMTP id 8609330409A; Tue, 24 Apr 2012 12:30:12 -0700 (PDT) Message-ID: <4F96FF42.606@sgi.com> Date: Tue, 24 Apr 2012 14:30:10 -0500 From: Mark Tinguely User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 MIME-Version: 1.0 To: Dave Chinner CC: xfs@oss.sgi.com Subject: Re: [PATCH 32/37] xfs: move xfs_get_extsz_hint() and kill xfs_rw.h References: <1335160747-17254-1-git-send-email-david@fromorbit.com> <1335160747-17254-33-git-send-email-david@fromorbit.com> In-Reply-To: <1335160747-17254-33-git-send-email-david@fromorbit.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 04/23/12 00:59, Dave Chinner wrote: > From: Dave Chinner > > The only thing left in xfs_rw.h is a function prototype for an inode > function. Move that to xfs_inode.h, and kill xfs_rw.h. > > Also move the function implementing the prototype from xfs_rw.c to > xfs_inode.c so we only have one function left in xfs_rw.c > > Signed-off-by: Dave Chinner > --- Looks good. Reviewed-by: Mark Tinguely