X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id pB58biT7122636 for ; Mon, 5 Dec 2011 02:37:44 -0600 X-ASG-Debug-ID: 1323074262-59b201ef0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 960FA107D91D for ; Mon, 5 Dec 2011 00:37:42 -0800 (PST) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id u2k4kqF85J9yDW3q for ; Mon, 05 Dec 2011 00:37:42 -0800 (PST) Received: from hch by bombadil.infradead.org with local (Exim 4.76 #1 (Red Hat Linux)) id 1RXU3R-0008WA-VV; Mon, 05 Dec 2011 08:37:42 +0000 Date: Mon, 5 Dec 2011 03:37:41 -0500 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 07/16] xfs: remove XFS_DQ_INACTIVE Subject: Re: [PATCH 07/16] xfs: remove XFS_DQ_INACTIVE Message-ID: <20111205083741.GB29401@infradead.org> References: <20111128082722.604873274@bombadil.infradead.org> <20111128082837.441012540@bombadil.infradead.org> <20111205042351.GN7046@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111205042351.GN7046@dastard> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: 173-166-109-252-newengland.hfc.comcastbusiness.net[173.166.109.252] X-Barracuda-Start-Time: 1323074263 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0017 1.0000 -2.0101 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.91 X-Barracuda-Spam-Status: No, SCORE=-1.91 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=RDNS_DYNAMIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.82190 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 RDNS_DYNAMIC Delivered to trusted network by host with dynamic-looking rDNS X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Mon, Dec 05, 2011 at 03:23:51PM +1100, Dave Chinner wrote: > > + xfs_qm_dqdestroy(dqp); > > return (0); > > } > > While there, you may as well make that a "return 0;" Indeed. > > - mutex_unlock(&xqm->qm_dqfrlist_lock); > > - mutex_destroy(&xqm->qm_dqfrlist_lock); > > kmem_free(xqm); > > } > > Don't we still need that mutex_destroy() call there? We never needed it - Linux does an implicit mutex_destory when freeing memory containing a mutex.