X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p8T10Mua150429 for ; Wed, 28 Sep 2011 20:00:22 -0500 X-ASG-Debug-ID: 1317258020-5d2d03af0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 611DA1C51C50; Wed, 28 Sep 2011 18:00:20 -0700 (PDT) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id cWHdW4XMB56oskCM; Wed, 28 Sep 2011 18:00:20 -0700 (PDT) Received: from hch by bombadil.infradead.org with local (Exim 4.76 #1 (Red Hat Linux)) id 1R94z6-0007qS-0J; Thu, 29 Sep 2011 01:00:20 +0000 Date: Wed, 28 Sep 2011 21:00:19 -0400 From: Christoph Hellwig To: Alex Elder Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 2/5] xfsprogs: libxcmd: simplify fs_table_lookup() Subject: Re: [PATCH 2/5] xfsprogs: libxcmd: simplify fs_table_lookup() Message-ID: <20110929010019.GB26863@infradead.org> References: <08dbe8c3d0f49bac0c18570a68e7aa983cb4c731.1317207144.git.aelder@sgi.com> <4790c40ad138f61ca542c7c0cb49987e43164a31.1317207144.git.aelder@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4790c40ad138f61ca542c7c0cb49987e43164a31.1317207144.git.aelder@sgi.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: 173-166-109-252-newengland.hfc.comcastbusiness.net[173.166.109.252] X-Barracuda-Start-Time: 1317258021 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0147 1.0000 -1.9254 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.83 X-Barracuda-Spam-Status: No, SCORE=-1.83 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=RDNS_DYNAMIC X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.75874 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.10 RDNS_DYNAMIC Delivered to trusted network by host with dynamic-looking rDNS X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Wed, Sep 28, 2011 at 05:57:09AM -0500, Alex Elder wrote: > Move a block of invariant code out of the loop in fs_table_lookup(), > and add a few comments. > > Signed-off-by: Alex Elder Looks good, Reviewed-by: Christoph Hellwig