X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham
	version=3.4.0-r929098
Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p7QFbSeX114264
	for <xfs@oss.sgi.com>; Fri, 26 Aug 2011 10:37:29 -0500
Received: from xmail.sgi.com (pv-excas3-dc21-nlb.corp.sgi.com [137.38.102.207])
	by relay2.corp.sgi.com (Postfix) with ESMTP id D696E30406A;
	Fri, 26 Aug 2011 08:37:25 -0700 (PDT)
Received: from [127.0.0.1] (128.162.232.50) by xmail.sgi.com (137.38.102.30)
 with Microsoft SMTP Server (TLS) id 14.1.289.1; Fri, 26 Aug 2011 10:37:25
 -0500
Subject: Re: [PATCH] xfsdump: refactor ring_create
From: Alex Elder <aelder@sgi.com>
Reply-To: <aelder@sgi.com>
To: Bill Kendall <wkendall@sgi.com>
CC: <xfs@oss.sgi.com>
In-Reply-To: <1313422998-7263-1-git-send-email-wkendall@sgi.com>
References: <1313422998-7263-1-git-send-email-wkendall@sgi.com>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 26 Aug 2011 10:37:25 -0500
Message-ID: <1314373045.2821.24.camel@doink>
MIME-Version: 1.0
X-Mailer: Evolution 2.32.2 
Content-Transfer-Encoding: 7bit
X-Originating-IP: [128.162.232.50]
X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com
X-Virus-Status: Clean

On Mon, 2011-08-15 at 10:43 -0500, Bill Kendall wrote:
> ring_create() takes a thread creation function pointer. The two
> callers of ring_create() pass pointers to identical but separate
> functions. This can be simplified by moving the thread creation
> code into ring_create() itself.
> 
> Signed-off-by: Bill Kendall <wkendall@sgi.com> 

Looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>