X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p5SBEfvm212075 for ; Tue, 28 Jun 2011 06:14:43 -0500 X-ASG-Debug-ID: 1309259680-365d00750000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mx1.redhat.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 675301D7C1AE; Tue, 28 Jun 2011 04:14:40 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id 5iK6uSddcvdCz3rD; Tue, 28 Jun 2011 04:14:40 -0700 (PDT) X-ASG-Whitelist: Barracuda Reputation Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5SBEbGG015603 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 28 Jun 2011 07:14:37 -0400 Received: from dhcp-1-248.brq.redhat.com (dhcp-1-248.brq.redhat.com [10.34.1.248]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5SBEXtY002214 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 28 Jun 2011 07:14:35 -0400 Date: Tue, 28 Jun 2011 13:14:33 +0200 (CEST) From: Lukas Czerner X-X-Sender: lukas@dhcp-27-109.brq.redhat.com To: Lukas Czerner cc: xfs@oss.sgi.com, aelder@sgi.com, david@fromorbit.com X-ASG-Orig-Subj: Re: [PATCH] xfs_repair: Check if agno is inside the filesystem Subject: Re: [PATCH] xfs_repair: Check if agno is inside the filesystem In-Reply-To: <1309255279-15608-1-git-send-email-lczerner@redhat.com> Message-ID: References: <1309255279-15608-1-git-send-email-lczerner@redhat.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Barracuda-Connect: mx1.redhat.com[209.132.183.28] X-Barracuda-Start-Time: 1309259681 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Tue, 28 Jun 2011, Lukas Czerner wrote: > When getting an inode tree pointer from an array inode_tree_ptrs, we > should check if agno, which is used as a pointer to the array, lives > within the file system, because if it is not, we can end up touching > uninitialized memory. > > This commit fixes it by passing xfs_mount to affected functions and > checking if agno really is inside the file system. > > This solves Red Hat bug #694706 > > Signed-off-by: Lukas Czerner > Reviewed-by: Dave Chinner I forgot to mention a version of the patch. This is version 2. Thanks! -Lukas