X-Spam-Checker-Version: SpamAssassin 3.4.0-r929098 (2010-03-30) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.4.0-r929098 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p0O8jCBY071522 for ; Mon, 24 Jan 2011 02:45:15 -0600 X-ASG-Debug-ID: 1295858854-7850013e0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 80C6915467E6 for ; Mon, 24 Jan 2011 00:47:34 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id JIspyX1RyGWPgatt for ; Mon, 24 Jan 2011 00:47:34 -0800 (PST) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.72 #1 (Red Hat Linux)) id 1PhI5E-000191-E4; Mon, 24 Jan 2011 08:47:32 +0000 Date: Mon, 24 Jan 2011 03:47:32 -0500 From: Christoph Hellwig To: Dave Chinner Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code Subject: Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code Message-ID: <20110124084732.GA4378@infradead.org> References: <1294649091-27174-1-git-send-email-david@fromorbit.com> <1294649091-27174-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1294649091-27174-3-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1295858855 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean > +typedef int32_t atomic_t; > +typedef int64_t atomic64_t; > + > +#define atomic_inc_return(x) (++(*(x))) > +#define atomic_dec_return(x) (--(*(x))) > + > +#define atomic64_read(x) *(x) > +#define atomic64_set(x, v) (*(x) = v) These defintions are pretty dangerous if we ever happens to use them in multi-threaded code like repair. Currently we're not, but they should grow a larger warning comment. > --- /dev/null > +++ b/include/hlist.h Why not add the hlist helpers to list.h, like in the kernel tree? Otherwise looks good, Reviewed-by: Christoph Hellwig