Date: Wed, 19 Jan 2011 06:39:01 -0500
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 07/12] xfs: kill xfs_fs_mount_cmn_err() macro
Message-ID: <20110119113900.GB12941@infradead.org>
References: <1294792553-8378-1-git-send-email-david@fromorbit.com>
 <1294792553-8378-8-git-send-email-david@fromorbit.com>
 <20110118130023.GA23988@infradead.org>
 <20110118214610.GW28803@dastard>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110118214610.GW28803@dastard>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Wed, Jan 19, 2011 at 08:46:10AM +1100, Dave Chinner wrote:
> > I would be nice to just move the quite flag into the normal mount flags
> > and have a xfs_mount_warn that checks it based off the mp.
> 
> Given it is a flag that is only relevant for the mount context, is
> there really any need to use a flag that persists for the entire
> life of the filesystem for it? I don't think the code is that hard
> to follow right now. ;)

We can clear the flag after the mount.  But in the end it's probably
not worth bothering, so feel free to leave it as-is.