Date: Tue, 30 Nov 2010 15:24:00 -0500
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/8] xfs: consume iodone callback items on buffers as
 they are processed
Message-ID: <20101130202400.GA5860@infradead.org>
References: <1290993152-20999-1-git-send-email-david@fromorbit.com>
 <1290993152-20999-6-git-send-email-david@fromorbit.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1290993152-20999-6-git-send-email-david@fromorbit.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Mon, Nov 29, 2010 at 12:12:29PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> To allow buffer iodone callbacks to consume multiple items off the
> callback list, first we need to convert the xfs_buf_do_callbacks()
> to consume items and always pull the next item from the head of the
> list.
> 
> The means the item list walk is never dependent on knowing the
> next item on the list and hence allows callbacks to remove itesm
> from the list as well. This allows callbacks to do bulk operations
> by scanning the list for identical callbacks, consuming them all
> and then processing them in bulk, negating the need for multiple
> callbacks of that type.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>