X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o1AFfWpw058443 for ; Wed, 10 Feb 2010 09:41:32 -0600 X-ASG-Debug-ID: 1265816564-278f039f0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from pu01.news-service.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id BB5EE139564B for ; Wed, 10 Feb 2010 07:42:44 -0800 (PST) Received: from pu01.news-service.com (ns1.news-service.com [195.114.240.3]) by cuda.sgi.com with ESMTP id ayDGLgEU0o2fzkq7 for ; Wed, 10 Feb 2010 07:42:44 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by pu01.news-service.com (Postfix) with ESMTP id C53E213E41; Wed, 10 Feb 2010 16:42:43 +0100 (CET) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: Debian amavisd-new at pu01.news-service.com Received: from pu01.news-service.com ([127.0.0.1]) by localhost (pu01.nse [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZOLqkgo+p9vx; Wed, 10 Feb 2010 16:42:41 +0100 (CET) Received: from [172.25.0.47] (nse01.nse [172.25.0.47]) by pu01.news-service.com (Postfix) with ESMTP id ABACA13E24; Wed, 10 Feb 2010 16:42:41 +0100 (CET) Message-ID: <4B72D3F3.2040308@news-service.com> Date: Wed, 10 Feb 2010 16:42:43 +0100 From: Patrick Schreurs User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1 MIME-Version: 1.0 To: Christoph Hellwig CC: Dave Chinner , Tommy van Leeuwen , xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH] Inode reclaim fixes (was Re: 2.6.31 xfs_fs_destroy_inode: cannot reclaim) Subject: Re: [PATCH] Inode reclaim fixes (was Re: 2.6.31 xfs_fs_destroy_inode: cannot reclaim) References: <4B3F9F88.9030307@news-service.com> <20100107110446.GA13802@discord.disaster> <4B45CFAC.4000607@news-service.com> <20100108113114.GA8654@discord.disaster> <4B504B03.7050604@news-service.com> <4B6706CE.1020207@news-service.com> <20100208194226.GD9527@infradead.org> <4B712166.9010701@news-service.com> <20100209103157.GA5197@infradead.org> <4B72A9D1.8030101@news-service.com> <20100210145508.GA29047@infradead.org> In-Reply-To: <20100210145508.GA29047@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ns1.news-service.com[195.114.240.3] X-Barracuda-Start-Time: 1265816565 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.22178 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean On 10-2-2010 15:55, Christoph Hellwig wrote: > On Wed, Feb 10, 2010 at 01:42:57PM +0100, Patrick Schreurs wrote: >> Thanks for the patch. After having this patch applied we saw *a lot* >> warnings. They all look like this: > > Ok, looks like that is not an issue, so you can discard that patch. > > I went down to the radix tree code to look for races in it's tag > handling, but then noticed that we might have an issue with our > usage of the radix-tree API. Can you try the patch below ontop > of Dave's rollup, and instead of my previous one? Okay. This patch is currently active. Thanks. I don't have a way to trigger it, so we'll have to wait and see what happens. Obviously we'll keep you posted. Have any of these patches been sent to the stable team? And have these patches been submitted to the upcoming 2.6.33 kernel? -Patrick