X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX,J_BACKHAIR_26 autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o1ACfkdO047507 for ; Wed, 10 Feb 2010 06:41:46 -0600 X-ASG-Debug-ID: 1265805777-1f10009e0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from pu01.news-service.com (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 0EE671C13C2 for ; Wed, 10 Feb 2010 04:42:58 -0800 (PST) Received: from pu01.news-service.com (ns1.news-service.com [195.114.240.3]) by cuda.sgi.com with ESMTP id 7QKqrlxiKoSGZlES for ; Wed, 10 Feb 2010 04:42:58 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by pu01.news-service.com (Postfix) with ESMTP id 1FB4313E41; Wed, 10 Feb 2010 13:42:57 +0100 (CET) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Scanned: Debian amavisd-new at pu01.news-service.com Received: from pu01.news-service.com ([127.0.0.1]) by localhost (pu01.nse [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M8al5kBE3ppn; Wed, 10 Feb 2010 13:42:54 +0100 (CET) Received: from [172.25.0.47] (nse01.nse [172.25.0.47]) by pu01.news-service.com (Postfix) with ESMTP id D533F13E24; Wed, 10 Feb 2010 13:42:54 +0100 (CET) Message-ID: <4B72A9D1.8030101@news-service.com> Date: Wed, 10 Feb 2010 13:42:57 +0100 From: Patrick Schreurs User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.7) Gecko/20100111 Thunderbird/3.0.1 MIME-Version: 1.0 To: Christoph Hellwig CC: Dave Chinner , Tommy van Leeuwen , xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH] Inode reclaim fixes (was Re: 2.6.31 xfs_fs_destroy_inode: cannot reclaim) Subject: Re: [PATCH] Inode reclaim fixes (was Re: 2.6.31 xfs_fs_destroy_inode: cannot reclaim) References: <4B0A8075.8080008@news-service.com> <20091211115932.GA20632@infradead.org> <4B3F9F88.9030307@news-service.com> <20100107110446.GA13802@discord.disaster> <4B45CFAC.4000607@news-service.com> <20100108113114.GA8654@discord.disaster> <4B504B03.7050604@news-service.com> <4B6706CE.1020207@news-service.com> <20100208194226.GD9527@infradead.org> <4B712166.9010701@news-service.com> <20100209103157.GA5197@infradead.org> In-Reply-To: <20100209103157.GA5197@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Barracuda-Connect: ns1.news-service.com[195.114.240.3] X-Barracuda-Start-Time: 1265805779 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.86 X-Barracuda-Spam-Status: No, SCORE=-0.86 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=BSF_RULE_7582B, INTERRUPTUS, INTERRUPTUS_2 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.22167 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.01 INTERRUPTUS RAW: Message looks to contain HTML-interrupted text 0.65 INTERRUPTUS_2 Message looks to contain HTML-interrupted text 0.50 BSF_RULE_7582B Custom Rule 7582B X-Virus-Status: Clean On 9-2-2010 11:31, Christoph Hellwig wrote: > On Tue, Feb 09, 2010 at 09:48:38AM +0100, Patrick Schreurs wrote: >> This is a clean 2.6.32.3 with the xfs-inode-reclaim-2.6.32 patch i >> received from Dave on January 8th (see attachment). > > I can't find anything interesting regarding I_RECLAIMABLE manipulation > in there. The only thing I could think off going wrong is i_flags > and i_update_core sitting in the same word and the compiler causing > some read-modify-write cycles for it. Can you test the patch below? > It fixes the abose issue up, and to make sure sure the assert you hit > isn't as lethal changes it into a WARN_ON, which will still print the > backtrace, but not crash the machine. Thanks for the patch. After having this patch applied we saw *a lot* warnings. They all look like this: Feb 10 13:20:38 sb06 kernel: ------------[ cut here ]------------ Feb 10 13:20:38 sb06 kernel: WARNING: at fs/xfs/linux-2.6/xfs_sync.c:768 xfs_reclaim_inode_now+0x3d/0x84() Feb 10 13:20:38 sb06 kernel: Hardware name: PowerEdge 1950 Feb 10 13:20:38 sb06 kernel: Modules linked in: acpi_cpufreq cpufreq_ondemand ipmi_si ipmi_devintf ipmi_msghandler bonding mptspi serio_raw rng_core scsi_transport_spi bnx2 thermal processor thermal_sys Feb 10 13:20:38 sb06 kernel: Pid: 3145, comm: xfssyncd Not tainted 2.6.32.3 #2 Feb 10 13:20:38 sb06 kernel: Call Trace: Feb 10 13:20:38 sb06 kernel: [] ? xfs_reclaim_inode_now+0x3d/0x84 Feb 10 13:20:38 sb06 kernel: [] ? xfs_reclaim_inode_now+0x3d/0x84 Feb 10 13:20:38 sb06 kernel: [] ? warn_slowpath_common+0x77/0xa3 Feb 10 13:20:38 sb06 kernel: [] ? xfs_reclaim_inode_now+0x3d/0x84 Feb 10 13:20:38 sb06 kernel: [] ? xfs_inode_ag_walk+0x68/0xa2 Feb 10 13:20:38 sb06 kernel: [] ? xfs_reclaim_inode_now+0x0/0x84 Feb 10 13:20:38 sb06 kernel: [] ? xfs_inode_ag_iterator+0x50/0x7e Feb 10 13:20:38 sb06 kernel: [] ? xfs_reclaim_inode_now+0x0/0x84 Feb 10 13:20:38 sb06 kernel: [] ? xfs_sync_worker+0x26/0x52 Feb 10 13:20:38 sb06 kernel: [] ? xfssyncd+0x123/0x180 Feb 10 13:20:38 sb06 kernel: [] ? xfssyncd+0x0/0x180 Feb 10 13:20:38 sb06 kernel: [] ? kthread+0x79/0x81 Feb 10 13:20:38 sb06 kernel: [] ? child_rip+0xa/0x20 Feb 10 13:20:38 sb06 kernel: [] ? kthread+0x0/0x81 Feb 10 13:20:38 sb06 kernel: [] ? child_rip+0x0/0x20 Feb 10 13:20:38 sb06 kernel: ---[ end trace 1ae862ca12666a87 ]--- and some look like this: Feb 10 13:20:38 sb06 kernel: ------------[ cut here ]------------ Feb 10 13:20:38 sb06 kernel: WARNING: at fs/xfs/linux-2.6/xfs_sync.c:768 xfs_reclaim_inode_now+0x3d/0x84() Feb 10 13:20:38 sb06 kernel: Hardware name: PowerEdge 1950 Feb 10 13:20:38 sb06 kernel: Modules linked in: acpi_cpufreq cpufreq_ondemand ipmi_si ipmi_devintf ipmi_msghandlerspes 13]n2r4a 2f1>nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospies 13nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13ode_no]n2r4a 2f1>nx85k7[<4x0-[e :7we_ospes 13nx85k7[<4x0-[e :7we_ospes 13] ? xfs_inode_ag_iterator+0x50/0x7e Feb 10 13:20:38 sb06 kernel: [] ? xfs_reclaim_inode_now+0x0/0x84 Feb 10 13:20:38 sb06 kernel: [] ? xfs_sync_worker+0x26/0x52 Feb 10 13:20:38 sb06 kernel: [] ? xfssyncd+0x123/0x180 Feb 10 13:20:38 sb06 kernel: [] ? xfssyncd+0x0/0x180 Feb 10 13:20:38 sb06 kernel: [] ? kthread+0x79/0x81 Feb 10 13:20:38 sb06 kernel: [] ? child_rip+0xa/0x20 Feb 10 13:20:38 sb06 kernel: [] ? kthread+0x0/0x81 Feb 10 13:20:38 sb06 kernel: [] ? child_rip+0x0/0x20 Feb 10 13:20:38 sb06 kernel: ---[ end trace 1ae862ca12666b1c ]--- I hope this clarifies things. If you need more info, don't hesitate to contact me. Thanks, -Patrick