X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00, FH_DATE_PAST_20XX autolearn=no version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0BAHhNH129660 for ; Mon, 11 Jan 2010 04:17:45 -0600 X-ASG-Debug-ID: 1263205118-178b01630000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6D69D1C40EAF for ; Mon, 11 Jan 2010 02:18:38 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id Ggsp201BtEwUYBCo for ; Mon, 11 Jan 2010 02:18:38 -0800 (PST) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.69 #1 (Red Hat Linux)) id 1NUHM4-0002Yg-Eo; Mon, 11 Jan 2010 10:18:36 +0000 Date: Mon, 11 Jan 2010 05:18:36 -0500 From: Christoph Hellwig To: Dave Chinner Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 1/4] xfs: reclaim inodes under a write lock Subject: Re: [PATCH 1/4] xfs: reclaim inodes under a write lock Message-ID: <20100111101836.GA26465@infradead.org> References: <1263167508-9346-1-git-send-email-david@fromorbit.com> <1263167508-9346-2-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1263167508-9346-2-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1263205118 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Mon, Jan 11, 2010 at 10:51:45AM +1100, Dave Chinner wrote: > Make the inode tree reclaim walk exclusive to avoid races with > concurrent sync walkers and lookups. This is a version of > a patch posted by Christoph Hellwig that avoids all the code > duplication. looks good, Reviewed-by: Christoph Hellwig FYI: I would rename xfs_reclaim_inode_now to just xfs_reclaim_inode, but unless Alex wants to edit it let's just get the patch in for now.