X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n4FHR3Um048925 for ; Fri, 15 May 2009 12:27:03 -0500 X-ASG-Debug-ID: 1242408431-7d7001040000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id ADA3128C5BC for ; Fri, 15 May 2009 10:27:11 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id lDxAO9haiQk6Yvyr for ; Fri, 15 May 2009 10:27:11 -0700 (PDT) X-ASG-Whitelist: Client Received: from hch by bombadil.infradead.org with local (Exim 4.69 #1 (Red Hat Linux)) id 1M51Bf-0000kg-CV; Fri, 15 May 2009 17:27:11 +0000 Date: Fri, 15 May 2009 13:27:11 -0400 From: Christoph Hellwig To: Eric Sandeen Cc: xfs-oss X-ASG-Orig-Subj: Re: [PATCH] xfsprogs: add fallocate command to xfs_io Subject: Re: [PATCH] xfsprogs: add fallocate command to xfs_io Message-ID: <20090515172711.GA23630@infradead.org> References: <4A077195.3070708@sandeen.net> <20090515171324.GA14804@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090515171324.GA14804@infradead.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1242408431 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Fri, May 15, 2009 at 01:13:24PM -0400, Christoph Hellwig wrote: > On Sun, May 10, 2009 at 07:30:13PM -0500, Eric Sandeen wrote: > > Based on Dave's earlier patch, but now we have an fallocate > > glibc call... this also adds autoconf magic and a manpage > > update. > > > > (hopefully not too #ifdef-heavy....) > > Looks good to me and seems to work. Actually that was spoken too fast. On my Debian -testing system it detects fallocate as available because exists, but the glibc doesn't actually support a falloc(3) yet. So either the detection needs to be improved or we need to use the raw syscall.