X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id n0N6M62j169004 for ; Fri, 23 Jan 2009 00:22:06 -0600 Received: from [IPv6:::1] (unknown [198.149.20.12]) by relay3.corp.sgi.com (Postfix) with ESMTP id 613C7AC004; Thu, 22 Jan 2009 22:21:15 -0800 (PST) In-Reply-To: <20090123000617.GB4970@infradead.org> References: <20090113142147.GE16333@alice> <20090120173455.GC21339@alice> <20090121035703.GH10158@disturbed> <200901211503.07308.nickpiggin@yahoo.com.au> <20090122043747.GU10158@disturbed> <20090122061158.GA31104@infradead.org> <20090123000203.GC32390@disturbed> <20090123000617.GB4970@infradead.org> Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <287917FE-424B-4DAD-B957-6B37C171E888@sgi.com> Cc: Nick Piggin , Eric Sesterhenn , Pavel Machek , Chris Mason , linux-kernel@vger.kernel.org, npiggin@yahoo.com.au, xfs@oss.sgi.com Content-Transfer-Encoding: 7bit From: Felix Blyakher Subject: Re: [PATCH] Re: Corrupted XFS log replay oops. Date: Fri, 23 Jan 2009 00:20:44 -0600 To: Christoph Hellwig X-Mailer: Apple Mail (2.753.1) X-Virus-Scanned: ClamAV version 0.94.2, clamav-milter version 0.94.2 on oss.sgi.com X-Virus-Status: Clean On Jan 22, 2009, at 6:06 PM, Christoph Hellwig wrote: >> [XFS] Check buffer lengths in log recovery >> >> Before trying to obtain, read or write a buffer, >> check that the buffer length is actually valid. If >> it is not valid, then something read in the recovery >> process has been corrupted and we should abort >> recovery. >> >> Reported-by: Eric Sesterhenn >> Signed-off-by: Dave Chinner >> Tested-by: Eric Sesterhenn > > > Reviewed-by: Christoph Hellwig Reviewed-by: Felix Blyakher