X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id mBV2uIla024223 for ; Tue, 30 Dec 2008 20:56:18 -0600 X-ASG-Debug-ID: 1230692175-4fcf02110000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from mail.sandeen.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id E03771799D9B for ; Tue, 30 Dec 2008 18:56:16 -0800 (PST) Received: from mail.sandeen.net (sandeen.net [209.173.210.139]) by cuda.sgi.com with ESMTP id ZtYV5h5FjOnM3t7f for ; Tue, 30 Dec 2008 18:56:16 -0800 (PST) Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sandeen.net (Postfix) with ESMTP id 24AFBA4B09A; Tue, 30 Dec 2008 20:55:42 -0600 (CST) Message-ID: <495ADF2D.8050709@sandeen.net> Date: Tue, 30 Dec 2008 20:55:41 -0600 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.18 (Macintosh/20081105) MIME-Version: 1.0 To: Christoph Hellwig CC: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 3/5] xfstests: test 195, add a testcase for the nodump flag Subject: Re: [PATCH 3/5] xfstests: test 195, add a testcase for the nodump flag References: <20081230230810.986105000@bombadil.infradead.org> <20081230230913.302710000@bombadil.infradead.org> In-Reply-To: <20081230230913.302710000@bombadil.infradead.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: sandeen.net[209.173.210.139] X-Barracuda-Start-Time: 1230692177 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.14033 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/8815/Tue Dec 30 15:57:57 2008 on oss.sgi.com X-Virus-Status: Clean Christoph Hellwig wrote: > Based on http://oss.sgi.com/bugzilla/show_bug.cgi?id=340. > > > Signed-off-by: Christoph Hellwig > > Index: xfstests/195 ... > +_do_dump() > +{ > + xfsdump -l 0 -s d -F \ > + -L prova -M prova \ > + -f $TEST_DIR/dumpfile -e -v excluded_files=debug $TEST_DIR \ > + | grep "ino $inum" \ > + | sed -e 's/xfsdump: pruned ino [0-9]*, owner 0, estimated size 0: skip flag set/xfsdump: pruned ino NNN, owner 0, estimated size 0: skip flag set/' > +} That's a bigger pattern than I'd have matched but as far as bike sheds go, looks good to me :) Reviewed-by: Eric Sandeen