X-Spam-Checker-Version: SpamAssassin 3.3.0-rupdated (updated) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.0-rupdated Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id mAK1t01m030052 for ; Wed, 19 Nov 2008 19:55:00 -0600 X-ASG-Debug-ID: 1227146093-1a6403020000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from sandeen.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C9BB51B29646 for ; Wed, 19 Nov 2008 17:54:53 -0800 (PST) Received: from sandeen.net (sandeen.net [209.173.210.139]) by cuda.sgi.com with ESMTP id AAz6BDc1LuOUTHdE for ; Wed, 19 Nov 2008 17:54:53 -0800 (PST) Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTP id 5279DA9C525; Wed, 19 Nov 2008 19:54:52 -0600 (CST) Message-ID: <4924C36B.6090700@sandeen.net> Date: Wed, 19 Nov 2008 19:54:51 -0600 From: Eric Sandeen User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914) MIME-Version: 1.0 To: Christoph Hellwig CC: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [patch 01/11] Move compat ioctl structs & numbers into xfs_ioctl32.h Subject: Re: [patch 01/11] Move compat ioctl structs & numbers into xfs_ioctl32.h References: <20081119044401.573365619@sandeen.net> <20081119044907.776640320@sandeen.net> <20081119145941.GA13050@infradead.org> <49242FAC.2060208@sandeen.net> In-Reply-To: <49242FAC.2060208@sandeen.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Barracuda-Connect: sandeen.net[209.173.210.139] X-Barracuda-Start-Time: 1227146098 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.10665 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Eric Sandeen wrote: >> I must also say that I don't really like these _copying helpers at all, >> just adding an explicit call to the underlying ioctl from them seems >> much clener than dispatching control back to the main routine with a >> changed argument and ioc number. > > Ok, either way is fine by me, was just following what was there already. So I went off to do it this way, and while I certainly can, (I'm almost done rewriting it this way) after a bit more thought I really don't see much wrong with just translating in the 32-bit args for any ioctl which is _IOW only... it doesn't seem that bad... any particular reason you're against it? -Eric