X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m8J9OXEh009879 for ; Fri, 19 Sep 2008 02:24:34 -0700 X-ASG-Debug-ID: 1221816366-396402590000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A153F91DEFF for ; Fri, 19 Sep 2008 02:26:06 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id pnf6unAbrdTZeUdQ for ; Fri, 19 Sep 2008 02:26:06 -0700 (PDT) Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1KgcFZ-0006ak-V5; Fri, 19 Sep 2008 09:26:05 +0000 Date: Fri, 19 Sep 2008 05:26:05 -0400 From: Christoph Hellwig To: Dave Chinner Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH 3/8] XFS: move the AIl traversal over to a consistent interface Subject: Re: [PATCH 3/8] XFS: move the AIl traversal over to a consistent interface Message-ID: <20080919092605.GC11443@infradead.org> References: <1221317877-8333-1-git-send-email-david@fromorbit.com> <1221317877-8333-4-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1221317877-8333-4-git-send-email-david@fromorbit.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1221816366 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.5953 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- On Sun, Sep 14, 2008 at 12:57:52AM +1000, Dave Chinner wrote: > With the new cursor interface, it makes sense to make all the > traversing code use the cursor interface and make the old one go > away. This means more of the AIL interfacing is done by passing > struct xfs_ail pointers around the place instead of struct > xfs_mount pointers. > > We can replace the use of xfs_trans_first_ail() in > xfs_log_need_covered() as it is only checking if the AIL is empty. > We can do that with a call to xfs_trans_ail_tail() instead, where a > zero LSN returned indicates and empty AIL... Looks good.