Received: with ECARTIS (v1.0.0; list xfs); Thu, 28 Aug 2008 18:19:18 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from larry.melbourne.sgi.com (larry.melbourne.sgi.com [134.14.52.130]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with SMTP id m7T1JCXW010789 for ; Thu, 28 Aug 2008 18:19:13 -0700 Received: from [134.14.55.216] (wererabbit.melbourne.sgi.com [134.14.55.216]) by larry.melbourne.sgi.com (950413.SGI.8.6.12/950213.SGI.AUTOCF) via ESMTP id LAA03657; Fri, 29 Aug 2008 11:20:27 +1000 Message-ID: <48B74EDB.7060407@sgi.com> Date: Fri, 29 Aug 2008 11:20:27 +1000 From: Peter Leckie User-Agent: Thunderbird 1.5.0.10 (X11/20070305) MIME-Version: 1.0 To: David Chinner CC: Christoph Hellwig , Peter Zijlstra , Lachlan McIlroy , Daniel J Blueman , Christoph Hellwig , xfs@oss.sgi.com Subject: Re: [2.6.27-rc4] XFS i_lock vs i_iolock... References: <6278d2220808221412x28f4ac5dl508884c8030b364a@mail.gmail.com> <20080825010213.GO5706@disturbed> <48B21507.9050708@sgi.com> <20080825035542.GR5706@disturbed> <1219647573.20732.28.camel@twins> <20080825215532.GB28188@lst.de> <20080826024547.GX5706@disturbed> <20080826193508.GA17542@infradead.org> In-Reply-To: <20080826193508.GA17542@infradead.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.91.2/8113/Thu Aug 28 16:49:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 17755 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: pleckie@sgi.com Precedence: bulk X-list: xfs Christoph Hellwig wrote: > Looks good. We probably don't need the #ifdef DEBUG as ASSERT is > debug-only anyway. Hey Dave did you want to update the patch?