Received: with ECARTIS (v1.0.0; list xfs); Sun, 31 Aug 2008 22:00:21 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham
	version=3.3.0-r574664
Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28])
	by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m814xxbU026918
	for <xfs@oss.sgi.com>; Sun, 31 Aug 2008 22:00:04 -0700
X-ASG-Debug-ID: 1220245245-2d0603730000-NocioJ
X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi
Received: from bombadil.infradead.org (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP
	id 29BDB73C169; Sun, 31 Aug 2008 22:00:45 -0700 (PDT)
Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id 5wXGCgauBtEaksrf; Sun, 31 Aug 2008 22:00:45 -0700 (PDT)
Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux))
	id 1Ka1Wv-0000kS-BV; Mon, 01 Sep 2008 05:00:45 +0000
Date: Mon, 1 Sep 2008 01:00:45 -0400
From: Christoph Hellwig <hch@infradead.org>
To: Barry Naujok <bnaujok@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
X-ASG-Orig-Subj: Re: [REVIEW #2]  Update kernel code to compile in userspace
	(libxfs)
Subject: Re: [REVIEW #2]  Update kernel code to compile in userspace
	(libxfs)
Message-ID: <20080901050045.GA1396@infradead.org>
References: <op.ugmy3u2o3jf8g2@pc-bnaujok.melbourne.sgi.com> <op.ugm1ttzb3jf8g2@pc-bnaujok.melbourne.sgi.com> <20080829181120.GA9455@infradead.org> <op.ugr4zpyv3jf8g2@pc-bnaujok.melbourne.sgi.com> <20080901015950.GA16825@infradead.org> <op.ugr5hsao3jf8g2@pc-bnaujok.melbourne.sgi.com> <20080901020826.GA31724@infradead.org> <op.ugsdamyd3jf8g2@pc-bnaujok.melbourne.sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <op.ugsdamyd3jf8g2@pc-bnaujok.melbourne.sgi.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org
	See http://www.infradead.org/rpr.html
X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34]
X-Barracuda-Start-Time: 1220245282
X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210
X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com
X-Barracuda-Spam-Score: -2.02
X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=
X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.4310
	Rule breakdown below
	 pts rule name              description
	---- ---------------------- --------------------------------------------------
X-Virus-Scanned: ClamAV 0.91.2/8122/Sat Aug 30 18:04:56 2008 on oss.sgi.com
X-Virus-Status: Clean
X-archive-position: 17773
X-ecartis-version: Ecartis v1.0.0
Sender: xfs-bounce@oss.sgi.com
Errors-to: xfs-bounce@oss.sgi.com
X-original-sender: hch@infradead.org
Precedence: bulk
X-list: xfs

> --- 2.6.x-xfs.orig/fs/xfs/xfs_ag.h
> +++ 2.6.x-xfs/fs/xfs/xfs_ag.h
> @@ -192,15 +192,16 @@ typedef struct xfs_perag
>  	xfs_agino_t	pagi_freecount;	/* number of free inodes */
>  	xfs_agino_t	pagi_count;	/* number of allocated inodes */
>  	int		pagb_count;	/* pagb slots in use */
> +	xfs_perag_busy_t *pagb_list;	/* unstable blocks */
>  #ifdef __KERNEL__
>  	spinlock_t	pagb_lock;	/* lock for pagb_list */
> -#endif
> -	xfs_perag_busy_t *pagb_list;	/* unstable blocks */
> +

Inside structures we should be more careful about reordering,
but this one looks fine becaus pagb_list and pagb_lock should
be in the same cache line either way.

The rest looks good, too.