Received: with ECARTIS (v1.0.0; list xfs); Tue, 05 Aug 2008 00:38:10 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham
	version=3.3.0-r574664
Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28])
	by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m757bGR6013656
	for <xfs@oss.sgi.com>; Tue, 5 Aug 2008 00:37:16 -0700
X-ASG-Debug-ID: 1217921910-5564030d0000-NocioJ
X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi
Received: from ipmail04.adl2.internode.on.net (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP id 26DBF1246C5E
	for <xfs@oss.sgi.com>; Tue,  5 Aug 2008 00:38:30 -0700 (PDT)
Received: from ipmail04.adl2.internode.on.net (ipmail04.adl2.internode.on.net [203.16.214.57]) by cuda.sgi.com with ESMTP id ttc85ZGPhUMG9Qeu for <xfs@oss.sgi.com>; Tue, 05 Aug 2008 00:38:30 -0700 (PDT)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AgUMAN+dl0h5LAiFXWdsb2JhbACKc4Y7Hpxn
X-IronPort-AV: E=Sophos;i="4.31,309,1215354600"; 
   d="scan'208";a="174561504"
Received: from ppp121-44-8-133.lns10.syd7.internode.on.net (HELO disturbed) ([121.44.8.133])
  by ipmail04.adl2.internode.on.net with ESMTP; 05 Aug 2008 17:08:27 +0930
Received: from dave by disturbed with local (Exim 4.69)
	(envelope-from <david@fromorbit.com>)
	id 1KQH7j-0001WX-4f; Tue, 05 Aug 2008 17:38:27 +1000
Date: Tue, 5 Aug 2008 17:38:27 +1000
From: Dave Chinner <david@fromorbit.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs@oss.sgi.com, xfs-dev <xfs-dev@sgi.com>
X-ASG-Orig-Subj: Re: [PATCH] Don't release root inode until finished using it
Subject: Re: [PATCH] Don't release root inode until finished using it
Message-ID: <20080805073827.GB21635@disturbed>
Mail-Followup-To: Lachlan McIlroy <lachlan@sgi.com>, xfs@oss.sgi.com,
	xfs-dev <xfs-dev@sgi.com>
References: <4897F434.2010309@sgi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4897F434.2010309@sgi.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Barracuda-Connect: ipmail04.adl2.internode.on.net[203.16.214.57]
X-Barracuda-Start-Time: 1217921911
X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210
X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com
X-Barracuda-Spam-Score: -2.02
X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests=
X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.1.1805
	Rule breakdown below
	 pts rule name              description
	---- ---------------------- --------------------------------------------------
X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com
X-Virus-Status: Clean
X-archive-position: 17387
X-ecartis-version: Ecartis v1.0.0
Sender: xfs-bounce@oss.sgi.com
Errors-to: xfs-bounce@oss.sgi.com
X-original-sender: david@fromorbit.com
Precedence: bulk
X-list: xfs

On Tue, Aug 05, 2008 at 04:33:24PM +1000, Lachlan McIlroy wrote:
> During unmount we're releasing the last reference on the root inode
> before we've finished using it so move it after the XFS_SEND_UNMOUNT
> hook.

Looks ok.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com