Received: with ECARTIS (v1.0.0; list xfs); Thu, 26 Jun 2008 01:19:26 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda2.sgi.com [192.48.168.29]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m5Q8JN0o007164 for ; Thu, 26 Jun 2008 01:19:24 -0700 X-ASG-Debug-ID: 1214468423-350b03be0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2AADA2836A8; Thu, 26 Jun 2008 01:20:23 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id LFuTT6Qbx3vy3gTu; Thu, 26 Jun 2008 01:20:23 -0700 (PDT) Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1KBmiN-0001zF-Ct; Thu, 26 Jun 2008 08:20:23 +0000 Date: Thu, 26 Jun 2008 04:20:23 -0400 From: Christoph Hellwig To: Lachlan McIlroy Cc: xfs-dev , xfs-oss X-ASG-Orig-Subj: Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize Subject: Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize Message-ID: <20080626082023.GA23954@infradead.org> References: <4863056D.3080209@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4863056D.3080209@sgi.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1214468424 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.54373 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 16558 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs On Thu, Jun 26, 2008 at 12:56:45PM +1000, Lachlan McIlroy wrote: > If we don't do the blocksize/PAGESIZE check before > calling xfs_sb_validate_fsb_count() we can assert > if we try to mount with a blocksize > pagesize. > The assert is valid so leave it and just move the > blocksize/pagesize check earlier. The patch looks good, but the subject is rather misleading, it should rather be something like: "move check for blocksize > pagesize later in the mount path"