Received: with ECARTIS (v1.0.0; list xfs); Wed, 25 Jun 2008 20:02:25 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m5Q32MdX026879 for ; Wed, 25 Jun 2008 20:02:22 -0700 X-ASG-Debug-ID: 1214449399-254b030e0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from ipmail01.adl6.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B4EF2D55DF4 for ; Wed, 25 Jun 2008 20:03:22 -0700 (PDT) Received: from ipmail01.adl6.internode.on.net (ipmail01.adl6.internode.on.net [203.16.214.146]) by cuda.sgi.com with ESMTP id BZbVimdZvxwQWhkk for ; Wed, 25 Jun 2008 20:03:22 -0700 (PDT) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjQDAEOGYkh5LG+uZWdsb2JhbACSXhICHqAH X-IronPort-AV: E=Sophos;i="4.27,706,1204464600"; d="scan'208";a="135556901" Received: from ppp121-44-111-174.lns10.syd6.internode.on.net (HELO disturbed) ([121.44.111.174]) by ipmail01.adl6.internode.on.net with ESMTP; 26 Jun 2008 12:33:16 +0930 Received: from dave by disturbed with local (Exim 4.69) (envelope-from ) id 1KBhlT-0000ui-Vz; Thu, 26 Jun 2008 13:03:16 +1000 Date: Thu, 26 Jun 2008 13:03:15 +1000 From: Dave Chinner To: Lachlan McIlroy Cc: xfs-dev , xfs-oss X-ASG-Orig-Subj: Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize Subject: Re: [PATCH] Don't assert if trying to mount with blocksize > pagesize Message-ID: <20080626030315.GG11558@disturbed> Mail-Followup-To: Lachlan McIlroy , xfs-dev , xfs-oss References: <4863056D.3080209@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4863056D.3080209@sgi.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-Barracuda-Connect: ipmail01.adl6.internode.on.net[203.16.214.146] X-Barracuda-Start-Time: 1214449403 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.54352 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 16539 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: david@fromorbit.com Precedence: bulk X-list: xfs On Thu, Jun 26, 2008 at 12:56:45PM +1000, Lachlan McIlroy wrote: > If we don't do the blocksize/PAGESIZE check before > calling xfs_sb_validate_fsb_count() we can assert > if we try to mount with a blocksize > pagesize. > The assert is valid so leave it and just move the > blocksize/pagesize check earlier. Yes, looks like a problem. The fix looks ok. Cheers, Dave. -- Dave Chinner david@fromorbit.com