Received: with ECARTIS (v1.0.0; list xfs); Thu, 19 Jun 2008 01:20:31 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.0-r574664 Received: from cuda.sgi.com (cuda1.sgi.com [192.48.168.28]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m5J8KQ0w006008 for ; Thu, 19 Jun 2008 01:20:27 -0700 X-ASG-Debug-ID: 1213863684-4fae02de0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 53BD3CF3985 for ; Thu, 19 Jun 2008 01:21:24 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id wtfXlQyVXUA9WBju for ; Thu, 19 Jun 2008 01:21:24 -0700 (PDT) Received: from hch by bombadil.infradead.org with local (Exim 4.68 #1 (Red Hat Linux)) id 1K9FOW-0007rR-EW; Thu, 19 Jun 2008 08:21:24 +0000 Date: Thu, 19 Jun 2008 04:21:24 -0400 From: Christoph Hellwig To: Michael-John Turner Cc: Christoph Hellwig , xfs@oss.sgi.com X-ASG-Orig-Subj: Re: Directory mtime update issue (kernel 2.6.25) Subject: Re: Directory mtime update issue (kernel 2.6.25) Message-ID: <20080619082124.GA24076@infradead.org> References: <20080618144534.GC11301@aurora.pimp.org.za> <20080618163356.GA6330@infradead.org> <20080618191045.GA10722@aurora.pimp.org.za> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080618191045.GA10722@aurora.pimp.org.za> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-Barracuda-Connect: bombadil.infradead.org[18.85.46.34] X-Barracuda-Start-Time: 1213863685 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0000 1.0000 -2.0210 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -2.02 X-Barracuda-Spam-Status: No, SCORE=-2.02 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.53714 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 16428 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@infradead.org Precedence: bulk X-list: xfs On Wed, Jun 18, 2008 at 08:10:45PM +0100, Michael-John Turner wrote: > Thanks for the prompt reply and the patch. I'm surprised this hasn't been > mentioned before as every other Unix filesystem I've used has not updated > the moved file's mtime during a rename(2). It's also odd that XFS only > changes the mtime when there's a new parent. > > What does everyone else think? Would it be possible to have this patch or a > similar one committed upstream? The patch also passes xfsqa, so it should be ready now.