Received: with ECARTIS (v1.0.0; list xfs); Wed, 18 Jun 2008 12:10:00 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.0-r574664 Received: from cuda.sgi.com ([192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m5IJ9vae018352 for ; Wed, 18 Jun 2008 12:09:57 -0700 X-ASG-Debug-ID: 1213816254-04b7014e0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from zen.pimp.org.za (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2ECFB17E2538 for ; Wed, 18 Jun 2008 12:10:54 -0700 (PDT) Received: from zen.pimp.org.za (zen.pimp.org.za [70.85.31.111]) by cuda.sgi.com with ESMTP id EIvHGruG43QRehTP for ; Wed, 18 Jun 2008 12:10:54 -0700 (PDT) Received: from area51.pimp.org.za (87-194-135-198.bethere.co.uk [87.194.135.198]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail-gateway.pimp.org.za", Issuer "Certificate Authority" (verified OK)) by zen.pimp.org.za (Postfix) with ESMTP id D860B449D; Wed, 18 Jun 2008 20:10:53 +0100 (BST) Received: from aurora.pimp.org.za (aurora.pimp.org.za [192.168.1.6]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by area51.pimp.org.za (Postfix) with ESMTPS id 8F6CC34846; Wed, 18 Jun 2008 20:10:28 +0100 (BST) Received: from localhost (localhost [127.0.0.1]) by aurora.pimp.org.za (Postfix) with ESMTP id 0BCA534833; Wed, 18 Jun 2008 20:10:51 +0100 (BST) X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Scanned: by amavisd-new 2.5.3 (NetBSD) at pimp.org.za Received: from aurora.pimp.org.za ([127.0.0.1]) by localhost (aurora.pimp.org.za [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3qrGS0sy6jDD; Wed, 18 Jun 2008 20:10:45 +0100 (BST) Received: by aurora.pimp.org.za (Postfix, from userid 1000) id 2568C34830; Wed, 18 Jun 2008 20:10:45 +0100 (BST) Date: Wed, 18 Jun 2008 20:10:45 +0100 From: Michael-John Turner To: Christoph Hellwig Cc: xfs@oss.sgi.com X-ASG-Orig-Subj: Re: Directory mtime update issue (kernel 2.6.25) Subject: Re: Directory mtime update issue (kernel 2.6.25) Message-ID: <20080618191045.GA10722@aurora.pimp.org.za> References: <20080618144534.GC11301@aurora.pimp.org.za> <20080618163356.GA6330@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080618163356.GA6330@infradead.org> User-Agent: Mutt/1.5.18 (NetBSD aurora.pimp.org.za 4.0_STABLE sparc64) X-Barracuda-Connect: zen.pimp.org.za[70.85.31.111] X-Barracuda-Start-Time: 1213816255 X-Barracuda-Bayes: INNOCENT GLOBAL 0.3517 1.0000 -0.1469 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -0.15 X-Barracuda-Spam-Status: No, SCORE=-0.15 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.53669 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Status: Clean X-archive-position: 16416 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: mj@mjturner.net Precedence: bulk X-list: xfs On Wed, Jun 18, 2008 at 12:33:56PM -0400, Christoph Hellwig wrote: > XFS does indeed updated the mtime too for the case when the source is > a directory and we get a new parent but just the ctime in all other > cases, which seems highly dubious to me. Thanks for the prompt reply and the patch. I'm surprised this hasn't been mentioned before as every other Unix filesystem I've used has not updated the moved file's mtime during a rename(2). It's also odd that XFS only changes the mtime when there's a new parent. What does everyone else think? Would it be possible to have this patch or a similar one committed upstream? -mj -- Michael-John Turner mj@mjturner.net <> http://mjturner.net/