Received: with ECARTIS (v1.0.0; list xfs); Wed, 18 Jun 2008 05:04:52 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.0-r574664 (2007-09-11) on oss.sgi.com X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.3.0-r574664 Received: from cuda.sgi.com ([192.48.176.15]) by oss.sgi.com (8.12.11.20060308/8.12.11/SuSE Linux 0.7) with ESMTP id m5IC4n83017683 for ; Wed, 18 Jun 2008 05:04:49 -0700 X-ASG-Debug-ID: 1213790745-0b6e012e0000-NocioJ X-Barracuda-URL: http://cuda.sgi.com:80/cgi-bin/mark.cgi Received: from verein.lst.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5F58417DF006; Wed, 18 Jun 2008 05:05:45 -0700 (PDT) Received: from verein.lst.de (verein.lst.de [213.95.11.210]) by cuda.sgi.com with ESMTP id QWCPjdkbMw0lVQAk; Wed, 18 Jun 2008 05:05:45 -0700 (PDT) Received: from verein.lst.de (localhost [127.0.0.1]) by verein.lst.de (8.12.3/8.12.3/Debian-7.1) with ESMTP id m5IC5aNW000570 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Wed, 18 Jun 2008 14:05:36 +0200 Received: (from hch@localhost) by verein.lst.de (8.12.3/8.12.3/Debian-6.6) id m5IC5aQD000560; Wed, 18 Jun 2008 14:05:36 +0200 Date: Wed, 18 Jun 2008 14:05:36 +0200 From: Christoph Hellwig To: Donald Douwsma Cc: Christoph Hellwig , xfs@oss.sgi.com X-ASG-Orig-Subj: Re: [PATCH] kill INDUCE_IO_ERROR Subject: Re: [PATCH] kill INDUCE_IO_ERROR Message-ID: <20080618120535.GA32691@lst.de> References: <20080523062323.GA32637@lst.de> <20080616101412.GA17939@lst.de> <485892D7.4080000@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <485892D7.4080000@sgi.com> User-Agent: Mutt/1.3.28i X-Scanned-By: MIMEDefang 2.39 X-Barracuda-Connect: verein.lst.de[213.95.11.210] X-Barracuda-Start-Time: 1213790747 X-Barracuda-Bayes: INNOCENT GLOBAL 0.0360 1.0000 -1.7883 X-Barracuda-Virus-Scanned: by cuda.sgi.com at sgi.com X-Barracuda-Spam-Score: -1.79 X-Barracuda-Spam-Status: No, SCORE=-1.79 using per-user scores of TAG_LEVEL=2.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=2.1 tests= X-Barracuda-Spam-Report: Code version 3.1, rules version 3.1.53637 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Virus-Scanned: ClamAV 0.91.2/6021/Wed Feb 27 15:55:48 2008 on oss.sgi.com X-Virus-Status: Clean X-archive-position: 16408 X-ecartis-version: Ecartis v1.0.0 Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com X-original-sender: hch@lst.de Precedence: bulk X-list: xfs On Wed, Jun 18, 2008 at 02:45:11PM +1000, Donald Douwsma wrote: > Christoph Hellwig wrote: > >On Fri, May 23, 2008 at 08:23:23AM +0200, Christoph Hellwig wrote: > >>All the error injection is already enabled through ifdef DEBUG, so kill > >>the never set second cpp symbol to activate it without the rest of the > >>debugging infrastructure. > > > >Can I get a review on this absolutely trivial patch? > > I'd like to keep INDUCE_IO_ERROR around so we have a way to introduce > ioerrors in release builds during testing. > > We could add it to xfs.h with the commented out QUOTADEBUG so people > know we still want to use it. cpp symbols not exposed by Kconfig will never get tested. If you thing it's really useful for release builds (which don't quite agree with) we should just enable it unconditionally. It's just in a few places, and any branch predictor worth it's name should take care of the additional branches without visible cost.